Skip to content

perf(OpenGLTexture): conditional getExtension call #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2022
Merged

perf(OpenGLTexture): conditional getExtension call #2629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions Sources/Rendering/OpenGL/Texture/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,10 +644,14 @@ function vtkOpenGLTexture(publicAPI, model) {

// if the opengl data type is half float
// then the data array must be u16
const halfFloatExt = model.context.getExtension('OES_texture_half_float');
const halfFloat = model._openGLRenderWindow.getWebgl2()
? model.openGLDataType === model.context.HALF_FLOAT
: halfFloatExt && model.openGLDataType === halfFloatExt.HALF_FLOAT_OES;
let halfFloat = false;
if (model._openGLRenderWindow.getWebgl2()) {
halfFloat = model.openGLDataType === model.context.HALF_FLOAT;
} else {
const halfFloatExt = model.context.getExtension('OES_texture_half_float');
halfFloat =
halfFloatExt && model.openGLDataType === halfFloatExt.HALF_FLOAT_OES;
}

if (halfFloat) {
for (let idx = 0; idx < data.length; idx++) {
Expand Down Expand Up @@ -1103,10 +1107,14 @@ function vtkOpenGLTexture(publicAPI, model) {
const useHalfFloatType = true;
publicAPI.getOpenGLDataType(dataType, useHalfFloatType);

const halfFloatExt = model.context.getExtension('OES_texture_half_float');
const useHalfFloat = model._openGLRenderWindow.getWebgl2()
? model.openGLDataType === model.context.HALF_FLOAT
: halfFloatExt && model.openGLDataType === halfFloatExt.HALF_FLOAT_OES;
let useHalfFloat = false;
if (model._openGLRenderWindow.getWebgl2()) {
useHalfFloat = model.openGLDataType === model.context.HALF_FLOAT;
} else {
const halfFloatExt = model.context.getExtension('OES_texture_half_float');
useHalfFloat =
halfFloatExt && model.openGLDataType === halfFloatExt.HALF_FLOAT_OES;
}

if (!useHalfFloat) {
return false;
Expand Down