docs(importmaps): use importmaps for external script#3200
docs(importmaps): use importmaps for external script#3200floryst merged 1 commit intoKitware:masterfrom
Conversation
a607867 to
e7023df
Compare
e7023df to
e3b5626
Compare
floryst
left a comment
There was a problem hiding this comment.
Overall looks good. I would like to request that we add the ES module code in addition to the UMD bundle. We can have two headings, such as "Using ES Modules" and "Using the UMD bundle", in that order.
|
@floryst when you say two headings, you mean one for |
|
Yes. I see you replaced the UMD code with the importmaps code. While I agree with moving forward with importmaps (esp given its support across major browsers), I would like to keep some of the UMD docs around for a bit longer. |
floryst
left a comment
There was a problem hiding this comment.
In revisiting this, I think we can go ahead and drop the UMD instructions. Modern baseline browsers support importmaps, and if we really need to support much older browsers, something else will likely break.
|
@sankhesh for me it's ok |
Context
Recommend the use of importmaps
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting