Skip to content

fix(OBJWriter): OffscreenCanvas doesn't have toBlob #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

fix(OBJWriter): OffscreenCanvas doesn't have toBlob #3298

merged 1 commit into from
Aug 12, 2025
+3 −1

Conversation

daker
Copy link
Collaborator

@daker daker commented Jul 27, 2025

Context

Due to a last minute change i switch to OffscreenCanvas which now causes an error to due to missing toBlob method

Uncaught (in promise) TypeError: s.toBlob is not a function
    at OBJWriter.js:1:631961
    at new Promise (<anonymous>)
    at e.exportAsZip (OBJWriter.js:1:631942)

Results

Switch back to document.createElement('canvas')

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

finetjul
finetjul approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sankhesh sankhesh added this pull request to the merge queue Aug 12, 2025
Merged via the queue into Kitware:master with commit 3722071 Aug 12, 2025
2 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 34.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Aug 12, 2025
@daker daker deleted the fix-objwriter branch August 12, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daker @finetjul @sankhesh