Skip to content

Conversation

daker
Copy link
Collaborator

@daker daker commented Jul 28, 2025

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot in the example gallery

@daker daker force-pushed the feat-ellipsearcsource branch from b25c5ee to b5f8c55 Compare July 28, 2025 13:11
@daker
Copy link
Collaborator Author

daker commented Jul 28, 2025

@finetjul Should be fine, let’s hope for no merge conflicts during the merge queue.

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daker daker force-pushed the feat-ellipsearcsource branch from b5f8c55 to 03f37ca Compare July 28, 2025 14:08
@sankhesh sankhesh added this pull request to the merge queue Aug 12, 2025
Merged via the queue into Kitware:master with commit 8b18519 Aug 12, 2025
2 checks passed
Copy link

🎉 This PR is included in version 34.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Aug 12, 2025
@daker daker deleted the feat-ellipsearcsource branch August 12, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants