Skip to content

feat(FrustumSource): add vtkFrustumSource #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(FrustumSource): add vtkFrustumSource #3301

wants to merge 1 commit into from
+490 −0

Conversation

daker
Copy link
Collaborator

@daker daker commented Jul 28, 2025 •
edited
Loading

Context

add vtkFrustumSource

⚠️REQUIRES : #3291 #3296

Results

image

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

finetjul
finetjul reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot in the sample gallery documentation.

@daker daker force-pushed the feat-frustumsource branch from 15e2383 to 7e25ebd Compare July 28, 2025 12:42
finetjul
finetjul approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(to be merged after vtkPlanes and vtkShrinkPolyData MRs)

@daker daker force-pushed the feat-frustumsource branch from 7e25ebd to 5343052 Compare August 12, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daker @finetjul