Skip to content

Conversation

daker
Copy link
Collaborator

@daker daker commented Jul 28, 2025

Context

add vtkFrustumSource

⚠️REQUIRES : #3291 #3296

Results

image

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot in the sample gallery documentation.

@daker daker force-pushed the feat-frustumsource branch from 15e2383 to 7e25ebd Compare July 28, 2025 12:42
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(to be merged after vtkPlanes and vtkShrinkPolyData MRs)

@daker daker force-pushed the feat-frustumsource branch from 7e25ebd to 5343052 Compare August 12, 2025 21:43
@daker daker force-pushed the feat-frustumsource branch from 5343052 to a62693b Compare August 20, 2025 22:40
@finetjul finetjul added this pull request to the merge queue Aug 28, 2025
Merged via the queue into Kitware:master with commit e26260d Aug 28, 2025
2 checks passed
Copy link

🎉 This PR is included in version 34.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Aug 28, 2025
@daker daker deleted the feat-frustumsource branch August 29, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants