Skip to content

fix(ESM): add type module to package.json #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

fix(ESM): add type module to package.json #3305

merged 1 commit into from
Aug 14, 2025

Conversation

daker
Copy link
Collaborator

@daker daker commented Aug 6, 2025

fixes #3080

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker marked this pull request as ready for review August 6, 2025 16:14
@daker
Copy link
Collaborator Author

daker commented Aug 6, 2025

@floryst FYI

floryst
floryst approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@floryst floryst added this pull request to the merge queue Aug 14, 2025
Merged via the queue into Kitware:master with commit d3a7db9 Aug 14, 2025
2 checks passed
@daker daker deleted the fix-esm-module branch August 29, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@floryst floryst floryst approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jadh4v jadh4v

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] ESM doesn't work without "type": "module" in node
3 participants
@daker @floryst @jadh4v