Skip to content

feat(PlatonicSolidSource): add vtkPlatonicSolidSource #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

feat(PlatonicSolidSource): add vtkPlatonicSolidSource #3308

merged 1 commit into from
Aug 12, 2025

Conversation

daker
Copy link
Collaborator

@daker daker commented Aug 11, 2025 •
edited
Loading

Context

Results

Example 1 Example 2
image image

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker marked this pull request as ready for review August 11, 2025 19:51
@daker daker force-pushed the feat-platonicsolidsource branch 3 times, most recently from 6575598 to 193f94e Compare August 11, 2025 20:22
finetjul
finetjul reviewed Aug 12, 2025
View reviewed changes
@daker daker force-pushed the feat-platonicsolidsource branch from 193f94e to 0d04037 Compare August 12, 2025 13:40
@daker daker force-pushed the feat-platonicsolidsource branch from 0d04037 to c3eafb9 Compare August 12, 2025 13:44
@daker daker requested a review from finetjul August 12, 2025 15:43
finetjul
finetjul approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sankhesh sankhesh added this pull request to the merge queue Aug 12, 2025
Merged via the queue into Kitware:master with commit 856b657 Aug 12, 2025
2 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 34.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Aug 12, 2025
@daker daker deleted the feat-platonicsolidsource branch August 12, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daker @finetjul @sankhesh