-
-
Notifications
You must be signed in to change notification settings - Fork 394
Revert center of rotation change after pan #3310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a938190
to
b087e01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be an option on the InteractorStyleManipulator ?
Folks camera control needs are diverse. Extention is the way. Kitchen sink camera controls are a trap. But InteractionStyleManipulator is a monster already, so maybe I'm missing something and we should put a option in there? |
From my side, I didn’t understand why the behaviour changed. It has been like this for a long time and didn’t seem to bother anyone. I get that the new behaviour can be useful, but perhaps it would have been better to add it as an option rather than changing the default. |
// Also allow pan with shift + left button | ||
const shiftPanManipulator = vtkMouseCameraTrackballPanManipulator.newInstance(); | ||
shiftPanManipulator.setButton(1); | ||
shiftPanManipulator.setShift(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have an option to enable or disable center of rotation modification. The default should remain the way it was before.
6bdc658
to
71890ad
Compare
Add vtkMouseCameraTrackballPanManipulatorAutoCenter closes #3309
71890ad
to
78d2d04
Compare
I rolled back the InteractorStyleManipulator behavior. Added a |
Rolls back InteractorStyleManipulator center of rotation behaior to not update on pan.
Adds
vtkMouseCameraTrackballPanManipulatorAutoCenter
for the auto update on center of rotation for mouse only input.Test with
npm run example InteractorStyleManipulator
Compare to
npm run example InteractorStyleManipulatorRotateCameraCenter
closes #3309