feat(CleanPolyData): add vtkCleanPolyData

[daker]

Context

Results

Changes

• Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

• semantic-release commit messages
• Run npm run reformat to have correctly formatted code

Testing

• This change adds or fixes unit tests
• Tested environment:
  • vtk.js:
  • OS:
  • Browser:

[daker]

@finetjul any chance i can get another review ? i will add a screenshot before the merge

[finetjul]

I'm not sure what the screenshot emphasize. Can you please explain ?

[daker]

@finetjul Well i am not sure what screenshot i can put there to illustrate the filter, it's the example screenshot with the toolbar hidden

[finetjul]

@finetjul Well i am not sure what screenshot i can put there to illustrate the filter, it's the example screenshot with the toolbar hidden

How about a before/after image:

[finetjul]

@finetjul Well i am not sure what screenshot i can put there to illustrate the filter, it's the example screenshot with the toolbar hidden

Actually I like your screenshot but it must keep the "panel" (make it bigger ?).
Can you compute normals on the output mesh ? that would emphasize that points have been merged.
Alternatively it could be a "collage" of the cube before/after cleaning like I did above.

[daker]

@finetjul maybe something like this (i didn't touched the normals)

[finetjul]

I'm not sure to understand the color scheme... (pleaes make the cube largers)

[daker]

@finetjul something like this ?

[finetjul]

Maybe with a glyph mapper to show that only 1 point is per face extremity.

[finetjul]

@daker
How about this one:

[daker]

@finetjul yes i was trying to do that after your comment but was stuck somehow, can you share the code ?

[finetjul]

I did it with Paraview and gimp:-)

[daker]

@finetjul I updated the example and replaced the screenshot.

[finetjul]

LGTM

[github-actions]

🎉 This PR is included in version 34.13.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀