Skip to content

Fix typing for vtkViewport.getViewport() #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finetjul merged 2 commits into from
Sep 17, 2025
Merged

Fix typing for vtkViewport.getViewport() #3328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610b93b
fix(typings): correct type for vtkViewport.getViewport()
ghetolay Sep 16, 2025
af13d3c
fix(typings): return type of `vtkViewport.getViewportByReference()` a…
ghetolay Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Sources/Rendering/Core/Viewport/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,19 @@ export interface vtkViewport extends vtkObject {
getSize(): Size;

/**
*
* Viewport for the Viewport to draw in the rendering window.
* Coordinates are expressed as (xmin,ymin,xmax,ymax), where each
* coordinate is 0 <= coordinate <= 1.0.
* @returns {Number[]}
* @see getViewportByReference()
* @see setViewport()
*/
getViewport(): vtkViewport;
getViewport(): [number, number, number, number];

/**
*
*/
getViewportByReference(): vtkViewport;
getViewportByReference(): [number, number, number, number];

/**
*
Expand Down