Skip to content

Fix vtkImageData typescript definitions for initialization values #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
finetjul merged 2 commits into from
Sep 17, 2025
Merged

Fix vtkImageData typescript definitions for initialization values #3329

finetjul merged 2 commits into from
Sep 17, 2025
+4 −1

Conversation

@jadh4v
Copy link
Collaborator

@jadh4v jadh4v commented Sep 16, 2025

Context

Include direction as a property of initialization values in the vtkImageData constructor. Direction property is already allowed but typescript definition did not include it, causing typescript errors on applications side.

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@jadh4v jadh4v self-assigned this Sep 16, 2025
@jadh4v jadh4v requested a review from finetjul September 16, 2025 23:47
finetjul
finetjul approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul added this pull request to the merge queue Sep 17, 2025
Merged via the queue into master with commit 7500dbe Sep 17, 2025
2 checks passed
@github-actions
Copy link

github-actions bot commented Sep 17, 2025

🎉 This PR is included in version 34.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Sep 17, 2025
@sankhesh sankhesh deleted the fix-vtkImageData-IImageDataInitialValues-typescript-def branch September 22, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@finetjul finetjul finetjul approved these changes

Assignees

@jadh4v jadh4v

Labels

released Automated label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jadh4v @finetjul