ENH: Do not disable ViewControllers module#9
Open
lassoan wants to merge 1 commit intoKitwareMedical:mainfrom
Open
ENH: Do not disable ViewControllers module#9lassoan wants to merge 1 commit intoKitwareMedical:mainfrom
lassoan wants to merge 1 commit intoKitwareMedical:mainfrom
Conversation
ViewControllers module is responsible for setting default view node properties from application settings. Developers may rely on this feature - see for example https://discourse.slicer.org/t/how-to-change-from-radiological-view-to-neurological-view/45744/8. Therefore it is better not to disable this module in the template.
Member
|
I now see that Suhaim raised a good question: why PR here instead of in https://github.com/KitwareMedical/SlicerCustomAppTemplate? |
Contributor
Author
|
https://github.com/KitwareMedical/SlicerCustomAppTemplate has to be updated as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViewControllers module is responsible for setting default view node properties from application settings.
Developers may rely on this feature - see for example https://discourse.slicer.org/t/how-to-change-from-radiological-view-to-neurological-view/45744/8.
Therefore it is better not to disable this module in the template.