feat(volumes): add volume display presets#64
Merged
Thibault-Pelletier merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
Collaborator
|
You PR is also missing at least one unit test to make sure the changed examples don't break from one version to another |
Collaborator
Author
I don't see how I could test that it does not break the previous versions. |
Collaborator
I didn't mean not breaking previous versions, I meant that future versions don't break newly added behavior (i.e. a non regression test) |
Collaborator
|
@Jo-Byr changes look good to me! |
Jo-Byr
force-pushed
the
volume-display-presets
branch
from
4d7a089 to
a90d46c
Compare
Thibault-Pelletier
force-pushed
the
volume-display-presets
branch
from
a90d46c to
284c445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Volume Display (slice) presets control.