Improve Scoop custom path detection#892
Open
breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
Open
Improve Scoop custom path detection#892breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Scoop detection for users with non-default or customized Scoop installations.
Changes
PATH, not only fromSCOOP/SCOOP_GLOBALenvironment variablesconfig.jsoncandidates and applyroot_path/global_pathoverrides when presentWhy
Some users install Scoop in custom locations or rely on PATH/shims instead of explicit environment variables. In those setups, detection can be incomplete or fail even though Scoop is installed and working.
This change makes detection more tolerant of real-world Scoop setups without changing the default behavior for standard installs.
Verification
Closes #887