Stabilize icon handle ownership#902
Open
breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
Open
Stabilize icon handle ownership#902breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
breshinotestachegira wants to merge 1 commit intoKlocman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #885
Summary
This PR hardens icon extraction and ownership handling to prevent corrupted or unstable icons.
Changes
Icon.FromHandle(...)results directlyDestroyIconWhy
The current code keeps icons created from native handles without taking ownership correctly.
That can lead to unstable icon state, leaks, or corrupted rendering over time.
Result
Icons used by BCU are now detached from temporary native handles and remain stable after extraction.