Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a base HTTPProtocol class to eliminate code duplication between the two HTTP protocol implementations (HttpToolsProtocol and H11Protocol). It extracts common initialization logic, attributes, and the connection_made method into the base class.
- Defines a new base
HTTPProtocolclass with shared initialization logic and common attributes - Refactors existing protocol classes to inherit from
HTTPProtocolinstead ofasyncio.Protocol - Updates transport parameter types from
asyncio.Transporttoasyncio.BaseTransportfor better type safety
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uvicorn/protocols/http/base.py | Defines the new HTTPProtocol base class with shared attributes and initialization |
| uvicorn/protocols/http/httptools_impl.py | Refactors HttpToolsProtocol to inherit from HTTPProtocol and removes duplicated code |
| uvicorn/protocols/http/h11_impl.py | Refactors H11Protocol to inherit from HTTPProtocol and removes duplicated code |
| uvicorn/protocols/utils.py | Updates transport parameter types to asyncio.BaseTransport |
| uvicorn/_types.py | Simplifies ASGI3Application type definition formatting |
| uvicorn/logging.py | Simplifies tuple unpacking formatting |
| tests/protocols/test_http.py | Updates test infrastructure to work with the new base class and type annotations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "client", | ||
| # Per-request state | ||
| "scope", | ||
| "headers", |
There was a problem hiding this comment.
The __slots__ declaration is missing the scheme attribute that is defined and used in the __init__ method and child classes. This could lead to runtime errors when trying to access the scheme attribute.
Suggested change
| "headers", | |
| "headers", | |
| "scheme", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.