fix: allow Ctrl+C to interrupt hanging lifespan#2752
Closed
theseriff wants to merge 0 commit intoKludex:mainfrom
Closed
fix: allow Ctrl+C to interrupt hanging lifespan#2752theseriff wants to merge 0 commit intoKludex:mainfrom
theseriff wants to merge 0 commit intoKludex:mainfrom
Conversation
theseriff
force-pushed
the
fix/hanging-lifespan
branch
from
8da545d to
c825f4e
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the issue where a hanging lifetime operation would cause the application to become unresponsive to Ctrl+C (SIGINT). Previously, if the startup and shutdown of the lifetime was hanging (for example, due to an infinite loop, deadlock, or a long-running operation), users would need to forcibly terminate the process using kill -9.
Fixes #2751
Checklist