Update same_as edge handling #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecies, add them to the merge
Collaborator
Author
|
happy to revise, but I'm going to YOLO-merge so that I can get past the broken url |
Contributor
|
I'm taking a quick look now, but feel free to merge and I'll follow up with a new PR if I see anything |
caufieldjh
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates handling of the upheno same_as edge handling so that we're using the updated upheno mapping files from data.monarchinitiative.org/mappings (monarch mapping commons). The same as edges weren't getting added to the kg before, so I added them to the merge, and updated the limitations to allow for all of the prefixes, not just HP-MP.