Skip to content

Fix: Inline now saved#238

Draft
Jaddison011 wants to merge 6 commits intomasterfrom
WEInlineBug
Draft

Fix: Inline now saved#238
Jaddison011 wants to merge 6 commits intomasterfrom
WEInlineBug

Conversation

@Jaddison011
Copy link
Copy Markdown

Summary

close #195

Checklist

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

  • Have you tested the changes? (pytest & dpytest)
  • Have you followed PEP-8 for naming and styling?
  • Has your code been properly documented with RestructuredText docstrings?
  • Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
  • If your code added new bot commands, have you updated documentation.json?

  • All of this code is your own, or follows the author repo's licence.

@Jaddison011 Jaddison011 requested a review from Kaspiaan August 3, 2021 13:05
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 3, 2021

Codecov Report

❌ Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.40%. Comparing base (3119f0d) to head (72ea332).
⚠️ Report is 531 commits behind head on master.

Files with missing lines Patch % Lines
cogs/ReactForRole.py 65.38% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   82.27%   82.40%   +0.13%     
==========================================
  Files          26       27       +1     
  Lines        6453     6560     +107     
==========================================
+ Hits         5309     5406      +97     
- Misses       1144     1154      +10     
Flag Coverage Δ
unittests 82.40% <65.38%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"""
sql_create_inline_all_status_table = """
CREATE TABLE IF NOT EXISTS InlineAllStatus (
guild_id integer NOT NULL,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guild_id should be text, this is fine for now as I can change it later.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to change now, removes the need for changing later

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed guild_id to be text

@JayDwee
Copy link
Copy Markdown
Member

JayDwee commented Aug 18, 2021

Code coverage of tests needs increasing pls

@Kaspiaan Kaspiaan self-assigned this Oct 18, 2021
@VirajShah18 VirajShah18 marked this pull request as draft November 9, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline not saved

3 participants