Skip to content

Error message improvements#321

Open
DatGuyChucky wants to merge 21 commits intomasterfrom
ErrorMessageImprovements
Open

Error message improvements#321
DatGuyChucky wants to merge 21 commits intomasterfrom
ErrorMessageImprovements

Conversation

@DatGuyChucky
Copy link
Copy Markdown
Contributor

@DatGuyChucky DatGuyChucky commented Aug 22, 2022

Summary

Improved error messages for CheckFailure, Forbidden, MissingRequiredArgument, and cog specific errors in verify and RFR

close #84

Checklist

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

  • Have you tested the changes? (pytest & dpytest)
  • Have you followed PEP-8 for naming and styling?
  • Has your code been properly documented with RestructuredText docstrings?
  • Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
  • If your code added new bot commands, have you updated documentation.json?

  • All of this code is your own, or follows the author repo's licence.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2022

Codecov Report

❌ Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.69%. Comparing base (9150cd8) to head (3aee502).
⚠️ Report is 160 commits behind head on master.

Files with missing lines Patch % Lines
koala/env.py 81.25% 3 Missing ⚠️
koala/cogs/react_for_role/cog.py 66.66% 2 Missing ⚠️
koala/cogs/verification/cog.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   86.72%   86.69%   -0.04%     
==========================================
  Files         111      111              
  Lines        8161     8172      +11     
==========================================
+ Hits         7078     7085       +7     
- Misses       1083     1087       +4     
Flag Coverage Δ
unittests 86.69% <76.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@JayDwee JayDwee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests need to be added to allow this to pass CodeCov check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More useful error messages

2 participants