-
Notifications
You must be signed in to change notification settings - Fork 4k
Update dresden_elektronik.ts to add scene switch #11070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/devices/dresden_elektronik.ts
Outdated
| }, | ||
| { | ||
| zigbeeModel: ["Lighting Switch"], | ||
| model: "Lighting Switch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use the model number written on the device/product page here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already is the reported model number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow there are some spaces at the end of the model id: "Scene Switch ", but when testing without the spaces the device was configured correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't have to be the reported model of the device, but the model number written on the product page or device itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, the model number as well as the product name is "Scene Switch" here.
https://www.dresden-elektronik.de/produkt/scene-switch.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would propose to use BN-600085 here
Removed Lighting Switch configuration and updated Scene Switch model.
|
You are right, Lighting Switch and Scene switch may be bit to vague, also I think ,I mixed up a part of my commits, this here should now have the correct model for the scene switch. |
|
Thanks! Could you also submit a picture for the docs (guide)? Make sure that the file name is |
Link to picture pull request: Koenkk/zigbee2mqtt.io#4589