Skip to content

Conversation

@xavierforestier
Copy link

Fix for version 2.6.0 that now depends on broker-factory, which fails to build :

npm verbose cli /usr/bin/node /usr/bin/npm
npm info using [email protected]
npm info using [email protected]
npm verbose title npm run build
npm verbose argv "run" "build" "--color" "false" "--foreground-scripts" "--offline" "--progress" "false" "--loglevel" "verbose" "--audit" "false"
npm verbose logfile logs-max:10 dir:/var/tmp/portage/app-misc/zigbee2mqtt-2.6.0/homedir/.npm/_logs/2025-08-04T07_53_54_587Z-
npm verbose logfile /var/tmp/portage/app-misc/zigbee2mqtt-2.6.0/homedir/.npm/_logs/2025-08-04T07_53_54_587Z-debug-0.log
npm http fetch GET https://registry.npmjs.org/npm attempt 1 failed with EAI_AGAIN

[email protected] build
tsc && node index.js writehash

node_modules/broker-factory/build/es2019/interfaces/default-broker-definition.d.ts:3:24 - error TS2749: 'MessagePort' refers to a value, but is being used as a type here. Did you mean 'typeof MessagePort'?

3     connect(): Promise<MessagePort>;
                         ~~~~~~~~~~~

node_modules/broker-factory/build/es2019/interfaces/default-broker-definition.d.ts:4:22 - error TS2749: 'MessagePort' refers to a value, but is being used as a type here. Did you mean 'typeof MessagePort'?

4     disconnect(port: MessagePort): Promise<void>;
                       ~~~~~~~~~~~

node_modules/broker-factory/build/es2019/module.d.ts:6:159 - error TS2749: 'MessagePort' refers to a value, but is being used as a type here. Did you mean 'typeof MessagePort'?

6 export declare const createBroker: <T extends IBrokerDefinition, U extends IWorkerDefinition>(brokerImplementation: TBrokerImplementation<T, U>) => ((sender: MessagePort | Worker) => T & IDefaultBrokerDefinition);
                                                                                                                                                                ~~~~~~~~~~~

node_modules/broker-factory/build/es2019/module.d.ts:6:173 - error TS2304: Cannot find name 'Worker'.

6 export declare const createBroker: <T extends IBrokerDefinition, U extends IWorkerDefinition>(brokerImplementation: TBrokerImplementation<T, U>) => ((sender: MessagePort | Worker) => T & IDefaultBrokerDefinition);

npm complains as MessagePort is not a type definition but a data.

…as a type here. Did you mean 'typeof MessagePort'?
@xavierforestier xavierforestier changed the base branch from master to dev August 5, 2025 20:12
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 5, 2025

CodSpeed Performance Report

Merging #28176 will degrade performances by 11.7%

Comparing xavierforestier:fix/lib_dom_missing (eec8d0c) with dev (2056b89)

Summary

❌ 1 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
[HA] receive MQTT message 785.7 µs 889.7 µs -11.7%

@Nerivec
Copy link
Collaborator

Nerivec commented Aug 5, 2025

The dom lib should not be used in this context (Z2M is nodejs).
Also broker-factory is not a Z2M dependency (in master or dev).
Looks like you may have something interfering?

@Nerivec Nerivec closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants