Fix new devices on restart, if serial not yet available.#24
Merged
KoljaWindeler merged 1 commit intoKoljaWindeler:masterfrom Mar 19, 2026
Merged
Fix new devices on restart, if serial not yet available.#24KoljaWindeler merged 1 commit intoKoljaWindeler:masterfrom
KoljaWindeler merged 1 commit intoKoljaWindeler:masterfrom
Conversation
|
This is the right fix. The core problem is that the old code tied the unique_id to data that isn't available yet at startup, so any slow or offline inverter triggered a new entity. IP-octet as stable fallback is a clean solution. Running a variation of this locally, no more duplicates. One-time cleanup is a reasonable tradeoff. Please merge this. |
Owner
|
thanks @shivan I'll give it a try here and report back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how I fixed the extra devices. At least for me I did not get any duplicated devices since some restarts.
So this could solve #23
But you first have to cleanup once, or you'll get a third device ;-)