Adding Swift base type to Sendable inherited type definition#114
Merged
Kolos65 merged 1 commit intoKolos65:mainfrom May 6, 2025
Merged
Adding Swift base type to Sendable inherited type definition#114Kolos65 merged 1 commit intoKolos65:mainfrom
Kolos65 merged 1 commit intoKolos65:mainfrom
Conversation
daniel-murphy-neurovalens
force-pushed
the
main
branch
2 times, most recently
from
127e915 to
95fa567
Compare
Contributor
Author
|
@Kolos65 that should be the commit message lint fixed, not too sure why the Linux builds are failing, seems to be an issue on your PR too |
Owner
|
Yeah, thats a swift toolchain issue I reported in pointfreeco/swift-issue-reporting#150 Don't worry about that, I will remove that version from the test matrix. |
Owner
|
|
daniel-murphy-neurovalens
force-pushed
the
main
branch
from
95fa567 to
0947055
Compare
Contributor
Author
|
Third times the charm 😅 |
Kolos65
approved these changes
May 6, 2025
Owner
|
Thanks @daniel-murphy-neurovalens 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves a pretty niche issue I ran into when using Mockable in conjunction with Bluejay, a bluetooth low energy library.
Bluejay has its own
Sendabletype which takes precidence overSwift.Sendablewhen it is imported within the file you are trying to mock within.The fix for this is to add a base type to the
Sendableinherited type definition, I don't think this will have any adverse side effects for other users where the clash is not an issue but it will allow for cases whereSendableis defined elsewhere.