Remove copy operations from classes in Kompute #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As for Issue KomputeProject#20, operations should be non-copy. Instead of creating a base NonCopyable class, I prefer to keep this inside the classes themselves, so that we do not create new inherited structures. Signed-off-by: Andrea Calabrese <[email protected]> Signed-off-by: Andrea Calabrese <[email protected]>
Same as previous commit Signed-off-by: Andrea Calabrese <[email protected]> Signed-off-by: Andrea Calabrese <[email protected]>
Signed-off-by: Andrea Calabrese <[email protected]> Signed-off-by: Andrea Calabrese <[email protected]>
Signed-off-by: Andrea Calabrese <[email protected]> Signed-off-by: Andrea Calabrese <[email protected]>
Signed-off-by: Andrea Calabrese <[email protected]> Signed-off-by: Andrea Calabrese <[email protected]>
Signed-off-by: Andrea Calabrese <[email protected]> Signed-off-by: Andrea Calabrese <[email protected]>
Signed-off-by: Andrea Calabrese <[email protected]> Signed-off-by: Andrea Calabrese <[email protected]>
Contributor
Author
|
@axsaucedo can you check if this is ok? My guess is that it should be, but I'll leave it to your review |
axsaucedo
approved these changes
Feb 18, 2025
Member
axsaucedo
left a comment
axsaucedo
left a comment
There was a problem hiding this comment.
LGTM - thank you for the contribution !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little different from what described in Issue #20, but I made all the classes in Kompute non-copy. I did not create the NonCopiable class, however the impossibility to copy the classes comes from each class: this is because I do not want to create a class without a purpose other than making the language behave as we want, and because it would not make the copy/assignment operators un-overridable, so it would be possible to do some terrible things and enable the copy on them.