Fix syntax error (MSVC) in Manager.cpp #418
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fix #417 |
Change VKAPI_PTR to VKAPI_ATTR Tested only on: MSVC version: `Microsoft (R) C/C++ Optimizing Compiler Version 19.43.34808 for x86` VulkanSDK version: 1.4.309.0 Latest kompute commit: 299b11f Signed-off-by: jamorphy <[email protected]>
axsaucedo
approved these changes
Mar 19, 2025
Member
axsaucedo
left a comment
axsaucedo
left a comment
There was a problem hiding this comment.
Thank you for the contribution
ArnoChenFx
pushed a commit
to ArnoChenFx/kompute
that referenced
this pull request
Jun 15, 2025
Change VKAPI_PTR to VKAPI_ATTR Tested only on: MSVC version: `Microsoft (R) C/C++ Optimizing Compiler Version 19.43.34808 for x86` VulkanSDK version: 1.4.309.0 Latest kompute commit: 299b11f Signed-off-by: jamorphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change VKAPI_PTR to VKAPI_ATTR
Tested only on:
MSVC version:
Microsoft (R) C/C++ Optimizing Compiler Version 19.43.34808 for x86VulkanSDK version: 1.4.309.0
Latest kompute commit: 299b11f