Skip to content

Conversation

@TinyTinni
Copy link
Contributor

Problem is, when trying to build kompute with cmake >=4 and building the tests. (-DKOMPUTE_OPT_BUILD_TESTS=ON)
The CMake configuration will fail. Similar to #422

CMake Error at build/_deps/googletest-src/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

Instead of workarounds, like setting KOMPUTE_OPT_USE_BUILT_IN_GOOGLE_TEST=OFF or CMAKE_POLICY_VERSION_MINIMUM=3.5, it would probably best to just update the dependency. The PR adds the currently most recent version of gtest.

Signed-off-by: Matthias Möller <[email protected]>
Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@axsaucedo axsaucedo merged commit 7024bb4 into KomputeProject:master Dec 5, 2025
9 checks passed
@TinyTinni TinyTinni deleted the update-gtest branch December 5, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants