feat: Use a bitset to represent the set of transformations#333
Draft
feat: Use a bitset to represent the set of transformations#333
Conversation
This is a breaking change from the _rust_ side, at least, since it changes publicly exported types (`LhsTransformations` and the `transformations` field of the `Lhs` type)
StarlightIbuki
approved these changes
Jan 27, 2026
StarlightIbuki
left a comment
There was a problem hiding this comment.
LGTM. I do not yet have time for an accurate bench. Maybe later, I will add a report of its improvement on Kong's overall performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change from the rust side, at least, since it changes publicly exported types (
LhsTransformationsand thetransformationsfield of theLhstype), so I bumped the version to 2.0. I'm not sure if we should really be exposing all these types and fields publicly (or if we even consider the rust API part of semver).This has a mild but consistent perf improvement with the benchmarks: