Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
- Coverage 29.53% 29.16% -0.37%
==========================================
Files 61 62 +1
Lines 6583 6666 +83
==========================================
Hits 1944 1944
- Misses 4500 4583 +83
Partials 139 139 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Converting to draft. I'm adding tests and they're uncovering some issues |
mheap
force-pushed
the
apply-command
branch
3 times, most recently
from
8f78216 to
a689d0d
Compare
mheap
force-pushed
the
apply-command
branch
4 times, most recently
from
1aaa089 to
226f98f
Compare
Member
Author
|
This is now ready for review. Once Kong/go-database-reconciler#143 is merged we can update |
Member
Author
|
Failing tests are due to #1483 |
mheap
force-pushed
the
apply-command
branch
2 times, most recently
from
7d2d789 to
3364815
Compare
Contributor
|
Just need to fix the commented out test-case. Rest looks good. |
The `deck gateway apply` command allows you to apply partial configuration to a running Gateway instance. To do this, it runs a `sync` with the NoDeletes flag enabled. This means that only new and existing resources are updated. Existing resources that do not exist in the declarative configuration file are left untouched.
Member
Author
|
@Prashansa-K I've rebased on |
Prashansa-K
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on Kong/go-database-reconciler#143 being merged and released
The
deck gateway applycommand allows you to apply partial configuration to a running Gateway instance.To do this, it runs a
syncwith the NoDeletes flag enabled. This means that only new and existing resources are updated. Existing resources that do not exist in the declarative configuration file are left untouched.