Catalog: Azure DevOps Integration#3647
Conversation
|
TuannasCodeCatastrophe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Waiting on icon - everything else ready. Request sent for icon. |
|
@TuannasCodeCatastrophe Could we please add preview links to the PR? |
…github.com/Kong/developer.konghq.com into feat-catalog-azure-devops-integration-3335
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Outdated
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Outdated
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-api.md
Outdated
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-api.md
Outdated
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-api.md
Outdated
Show resolved
Hide resolved
|
@TuannasCodeCatastrophe You can make this pass by turning vale off on the |
Guaris
left a comment
There was a problem hiding this comment.
The API instructions worked for me after changing the environment variable, the UI instructions did not. Run through the doc one more time, and make sure everything works from top to bottom. UI and API. There may have been changes since you wrote it that need to be accounted for.
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Outdated
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Outdated
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Outdated
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-api.md
Outdated
Show resolved
Hide resolved
…the-konnect-ui.md Co-authored-by: Angel <Guaris@users.noreply.github.com>
…the-konnect-api.md Co-authored-by: Angel <Guaris@users.noreply.github.com>
There was a problem hiding this comment.
For the UI doc:
- Change the Tl;DR so that its more clear what the doc is actually doing
- Rename the
azure-devops-apivariable to something likeazure-devops-repository - In step 2, add a sentence that explains what it is you are actually adding (If relevant add this to the API doc as well)
- Run through both the UI and API docs again, by yourself, and make sure that the workflow is working from top-to-bottom as expected.
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Outdated
Show resolved
Hide resolved
app/_how-tos/connect-azure-devops-to-the-konnect-catalog-with-the-konnect-ui.md
Show resolved
Hide resolved
This is missing, you have to add to the front matter the bindeable entities. @TuannasCodeCatastrophe
|
|
@DaniellaFreese This is ready for you |

Description
Fixes #3335
Preview Links
Checklist
descriptionentry in frontmatter.