feat: skip default injection in entities before sync#391
Open
Prashansa-K wants to merge 2 commits intorefactor/schema-managementfrom
Open
feat: skip default injection in entities before sync#391Prashansa-K wants to merge 2 commits intorefactor/schema-managementfrom
Prashansa-K wants to merge 2 commits intorefactor/schema-managementfrom
Conversation
Prashansa-K
changed the title
Collaborator
Author
|
This is ready to review. Konnect testing is completed here: https://github.com/Kong/deck/actions/runs/22627365616/job/65567998858 |
Prashansa-K
force-pushed
the
feat/skip-default-injection
branch
from
ed9ab21 to
b2e87f1
Compare
Prashansa-K
force-pushed
the
refactor/schema-management
branch
from
c8b395f to
9fa8bcd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/schema-management #391 +/- ##
==============================================================
- Coverage 28.67% 28.53% -0.15%
==============================================================
Files 121 121
Lines 16374 16477 +103
==============================================================
+ Hits 4695 4701 +6
- Misses 11063 11159 +96
- Partials 616 617 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Tests and changes for dual flows - default injection and without are added here: Kong/deck#1904 |
| client *kong.Client | ||
| ctx context.Context | ||
|
|
||
| schemasCache map[string]map[string]interface{} |
Contributor
There was a problem hiding this comment.
out of curiosity - since this is a private member of this struct, and the struct itself is a private member of this package, I couldn't find any instance if this being used in the past within this package - please correct me if I'm wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows deck to sync/diff/apply changes for entities without
injecting defaults.
Defaults are stripped from the dumped state - current state.
For target state, defaults are not injected at all. Further, defaults that
may already be present in the target content are stripped as well.
To ensure that diffing works correctly, we are allowing the differ
to use the schema and default caches to utilise them before generating
a diff.
Issues resolved
For Kong/deck#1842
Documentation
Testing