Skip to content

Commit 57bbb8b

Browse files
authored
Merge pull request #180 from Kong/fix/sensitive-content-length
filter out custom content length header
2 parents d8cd876 + 24f473f commit 57bbb8b

File tree

6 files changed

+15
-5
lines changed

6 files changed

+15
-5
lines changed

.vscode/settings.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
{
2-
"editor.formatOnSave": true,
2+
"editor.codeActionsOnSave": {
3+
"quickfix.biome": "explicit"
4+
},
35
"[javascript]": {
46
"editor.defaultFormatter": "biomejs.biome"
57
},

biome.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"$schema": "https://biomejs.dev/schemas/1.4.1/schema.json",
2+
"$schema": "https://biomejs.dev/schemas/1.7.3/schema.json",
33
"organizeImports": {
44
"enabled": true
55
},

lib/routes/bins/create.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ module.exports = (client) => (req, res, next) => {
4040
}
4141

4242
mock.content.size = 0;
43+
// express is sensitive to mismatched content-length header
44+
mock.headers = mock.headers.filter(
45+
(header) => header.name.toLowerCase() !== "content-length",
46+
);
4347

4448
validate
4549
.response(mock)

lib/routes/bins/update.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ module.exports = (client) => (req, res, next) => {
3737
}
3838

3939
mock.content.size = 0;
40+
// express is sensitive to mismatched content-length header
41+
mock.headers = mock.headers.filter(
42+
(header) => header.name.toLowerCase() !== "content-length",
43+
);
4044

4145
validate
4246
.response(mock)

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "2.0.2",
2+
"version": "2.0.3",
33
"name": "mockbin",
44
"description": "Test, mock, and track HTTP requests & responses between libraries, sockets and APIs",
55
"author": "Kong (https://www.konghq.com/)",

0 commit comments

Comments
 (0)