-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: Add state and scope input UI for MCP OAuth parameter #9507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Circular References ReportGenerated at: 2025-12-24T06:47:15.337Z Summary
Click to view all circular references in PR (167)Click to view all circular references in base branch (167)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for state and scope OAuth parameters in MCP authentication, enables public OAuth client support, and improves debugging by allowing MCP requests to be sent even when parameters are invalid.
- Added
stateandscopeinput fields to the MCP OAuth authentication UI - Refined OAuth logic to handle public OAuth clients (empty client secrets)
- Changed validation behavior to not block MCP requests when parameters are invalid
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/insomnia/src/ui/components/editors/auth/o-auth-2-auth.tsx |
Added state and scope fields to the basic configuration section for MCP auth flow |
packages/insomnia/src/main/mcp/oauth-client-provider.ts |
Added logic to handle empty client_secret for public OAuth clients and implemented state() method to provide state parameter |
packages/insomnia/src/main/mcp/transport-streamable-http.ts |
Enhanced scope extraction from WWW-Authenticate header with fallback logic and pass scope to auth function |
packages/insomnia/src/ui/components/mcp/mcp-request-pane.tsx |
Changed validation to non-blocking - validation is called but errors don't prevent sending requests |
packages/insomnia/src/ui/components/viewers/response-error-viewer.tsx |
Conditionally hide error message details for MCP responses while keeping help content visible |
packages/insomnia/src/ui/components/websockets/realtime-response-pane.tsx |
Pass isMcpResponse flag to ResponseErrorViewer for conditional error rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/insomnia/src/ui/components/viewers/response-error-viewer.tsx
Outdated
Show resolved
Hide resolved
…on errors for debug purpose
9e60bba to
56b672f
Compare
Changes
stateandscopeparameter for MCP OAuthINS-1861
Closes #9505