Conversation
pmalek
left a comment
There was a problem hiding this comment.
Actually there's one caveat: this should only happen for releases that are marked as latest.
Otherwise, if we already released 2.1, we'll overwrite the CRDs with 2.0.7.
Yes, once #2642 is merged, will that mitigate this issue? Or, I can add a check to see whether the |
#2642 will only make sure that links are version aware. If the scenario I mentioned above happens, docs specific for 2.1 would get removed. |
3e2e881 to
bcf2d43
Compare
|
@pmalek, sorry for the delay. The current workflow already has a condition that checks whether it is the create-docs-pr:
runs-on: ubuntu-latest
if: ${{ inputs.latest }}Are there any other changes I need to make in this PR to move it forward? Thank you! |
Ok that's good. I think in that case we can merge it. One tiny thing I'd change here is to add a description to the kong-operator/.github/workflows/__release-workflow.yaml Lines 39 to 42 in d264fb9 This means that if 2.2 has been released, and we're releasing 2.1.1 |
|
Yes, I agree. We should only set |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
bcf2d43 to
35468b0
Compare
What this PR does / why we need it:
Which issue this PR fixes
Fixes #35
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes