Skip to content

CI: add sync CRD reference step#2775

Merged
tao12345666333 merged 3 commits intomainfrom
sync-crd-reference-step
Jan 22, 2026
Merged

CI: add sync CRD reference step#2775
tao12345666333 merged 3 commits intomainfrom
sync-crd-reference-step

Conversation

@tao12345666333
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes

Fixes #35

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@tao12345666333 tao12345666333 self-assigned this Nov 28, 2025
@tao12345666333 tao12345666333 marked this pull request as ready for review December 1, 2025 09:11
@tao12345666333 tao12345666333 requested a review from a team as a code owner December 1, 2025 09:11
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there's one caveat: this should only happen for releases that are marked as latest.

Otherwise, if we already released 2.1, we'll overwrite the CRDs with 2.0.7.

@tao12345666333
Copy link
Member Author

tao12345666333 commented Dec 1, 2025

Actually there's one caveat: this should only happen for releases that are marked as latest.

Yes, once #2642 is merged, will that mitigate this issue?

Or, I can add a check to see whether the latest has been set?

@pmalek
Copy link
Member

pmalek commented Dec 1, 2025

Actually there's one caveat: this should only happen for releases that are marked as latest.

Yes, once #2642 is merged, will that mitigate this issue?

Or, I can add a check to see whether the latest has been set?

#2642 will only make sure that links are version aware. If the scenario I mentioned above happens, docs specific for 2.1 would get removed.

@tao12345666333 tao12345666333 force-pushed the sync-crd-reference-step branch from 3e2e881 to bcf2d43 Compare January 19, 2026 16:39
@tao12345666333
Copy link
Member Author

@pmalek, sorry for the delay. The current workflow already has a condition that checks whether it is the latest, so it will only run when latest is set.

 create-docs-pr:
    runs-on: ubuntu-latest
    if: ${{ inputs.latest }}

https://github.com/Kong/kong-operator/pull/2775/changes#diff-88c290694df2f071e377f4435912af49059b0289f9bfc24a1a90eca2949ebaf4R361

Are there any other changes I need to make in this PR to move it forward? Thank you!

@pmalek
Copy link
Member

pmalek commented Jan 20, 2026

@pmalek, sorry for the delay. The current workflow already has a condition that checks whether it is the latest, so it will only run when latest is set.

 create-docs-pr:
    runs-on: ubuntu-latest
    if: ${{ inputs.latest }}

https://github.com/Kong/kong-operator/pull/2775/changes#diff-88c290694df2f071e377f4435912af49059b0289f9bfc24a1a90eca2949ebaf4R361

Are there any other changes I need to make in this PR to move it forward? Thank you!

Ok that's good. I think in that case we can merge it. One tiny thing I'd change here is to add a description to the latest flag at

latest:
description: Whether to mark this release latest
type: boolean
default: false
so that latest is not set to true if a newer major or minor has been released.

This means that if 2.2 has been released, and we're releasing 2.1.1 latest should not be set. Otherwise the docs will be overwritten which is not what we'd want. Do you agree?

@tao12345666333
Copy link
Member Author

tao12345666333 commented Jan 20, 2026

Yes, I agree. We should only set latest to true when the released version number is the current maximum. 35468b0

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 added this pull request to the merge queue Jan 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2026
@tao12345666333 tao12345666333 added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 0c69f25 Jan 22, 2026
52 of 53 checks passed
@tao12345666333 tao12345666333 deleted the sync-crd-reference-step branch January 22, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate developers.konghq.com PR creation during release

2 participants