Skip to content

fix: fix ControlPlane status update#2961

Merged
pmalek merged 2 commits intomainfrom
fix-TestControlPlaneUpdate
Jan 29, 2026
Merged

fix: fix ControlPlane status update#2961
pmalek merged 2 commits intomainfrom
fix-TestControlPlaneUpdate

Conversation

@pmalek
Copy link
Member

@pmalek pmalek commented Dec 22, 2025

What this PR does / why we need it:

This handles cases where the status was not yet updated (e.g., after an update to the spec that changed controllers/feature gates).

Without this change we sometimes do get failures in tests where the status is not as the spec would indicate so.

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek self-assigned this Dec 22, 2025
@pmalek pmalek force-pushed the fix-TestControlPlaneUpdate branch 2 times, most recently from 9235c8d to 0b210a8 Compare December 22, 2025 13:44
@pmalek pmalek force-pushed the fix-TestControlPlaneUpdate branch from 0b210a8 to dfe7d50 Compare January 7, 2026 10:08
@pmalek pmalek force-pushed the fix-TestControlPlaneUpdate branch from dfe7d50 to a1415f2 Compare January 14, 2026 10:12
@pmalek
Copy link
Member Author

pmalek commented Jan 14, 2026

Observing errors in integration tests:

2026-01-14T10:31:49.5353144Z 2026-01-14T10:25:17Z	DEBUG	KonnectExtension	reconciling
2026-01-14T10:31:49.5353418Z 2026-01-14T10:25:17Z	DEBUG	KonnectExtension	DataPlane certificate validity checked
2026-01-14T10:31:49.5353901Z 2026-01-14T10:25:17Z	DEBUG	KonnectExtension	ControlPlane not found, for KonnectExtension during deletion, proceeding with cleanup
2026-01-14T10:31:49.5354208Z 2026-01-14T10:25:17Z	DEBUG	KonnectExtension	controlPlane reference validity checked
2026-01-14T10:31:49.5356104Z 2026-01-14T10:25:17Z	ERROR	Reconciler error	{"controller": "konnectextension", "controllerGroup": "konnect.konghq.com", "controllerKind": "KonnectExtension", "KonnectExtension": {"name":"fd57c0f1-f65c-4044-90fa-4c7f9c453000-rl8pr","namespace":"53d2abb8-d512-42ce-89c2-fd9fd64a1cd3"}, "namespace": "53d2abb8-d512-42ce-89c2-fd9fd64a1cd3", "name": "fd57c0f1-f65c-4044-90fa-4c7f9c453000-rl8pr", "reconcileID": "1a325ef5-8fd7-4197-bbcd-34377ff893e2", "error": "cannot determine KonnectAPIAuthConfiguration reference"}
2026-01-14T10:31:49.5356475Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
2026-01-14T10:31:49.5356865Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.4/pkg/internal/controller/controller.go:474
2026-01-14T10:31:49.5357233Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
2026-01-14T10:31:49.5357652Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.4/pkg/internal/controller/controller.go:421
2026-01-14T10:31:49.5357931Z sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func1.1
2026-01-14T10:31:49.5358329Z 	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.4/pkg/internal/controller/controller.go:296

@pmalek pmalek force-pushed the fix-TestControlPlaneUpdate branch 3 times, most recently from 41bb27d to 703d001 Compare January 28, 2026 18:04
@pmalek pmalek marked this pull request as ready for review January 28, 2026 20:22
@pmalek pmalek requested a review from a team as a code owner January 28, 2026 20:22
@pmalek pmalek force-pushed the fix-TestControlPlaneUpdate branch from c65fdea to c199807 Compare January 29, 2026 09:28
@pmalek pmalek added this to the KO v2.1.x milestone Jan 29, 2026
@pmalek pmalek force-pushed the fix-TestControlPlaneUpdate branch from c199807 to 5801ccd Compare January 29, 2026 10:16
@pmalek pmalek merged commit a6f8ddd into main Jan 29, 2026
51 of 52 checks passed
@pmalek pmalek deleted the fix-TestControlPlaneUpdate branch January 29, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants