fix: instrumentation http needs required attributes#14745
Closed
victordrnd wants to merge 1 commit intoKong:masterfrom
Closed
fix: instrumentation http needs required attributes#14745victordrnd wants to merge 1 commit intoKong:masterfrom
victordrnd wants to merge 1 commit intoKong:masterfrom
Conversation
According to https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/trace/semantic_conventions/http.md The http.method attribute is required in Opentelemetry to match an HTTP span.
|
|
Author
|
Seems related to #14381 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/trace/semantic_conventions/http.md
The Opentelemetry "http.method" attribute is required to match an HTTP span. This allows to resolve the dependencies tree in Elastic APM by completing the span.destination.service.name field.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md