fix: column sort indications reflect truth [MA-4062]#2808
Open
fix: column sort indications reflect truth [MA-4062]#2808
Conversation
Chalks
requested review from
a team,
Justineo,
adamdehaven and
jillztom
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Chalks
force-pushed
the
fix/table-sort-ma-4062
branch
from
24952a5 to
7bb38fd
Compare
Collaborator
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adamdehaven
requested changes
Jun 27, 2025
| /** this property defines whether sort icon should be displayed next to the column header and whether the column header will emit sort event upon clicking on it */ | ||
| sortable?: boolean | ||
| /** When provided, determines the intial arrow direction on the column header, if more than one header has this value only the first is applied */ | ||
| initialSort?: 'asc' | 'desc' |
Member
There was a problem hiding this comment.
There's already a sortColumnOrder prop exposed via tablePreferences - shouldn't that be sufficient?
| /** this property defines whether sort icon should be displayed next to the column header and whether the column header will emit sort event upon clicking on it */ | ||
| sortable?: boolean | ||
| /** When provided, determines the intial arrow direction on the column header, if more than one header has this value only the first is applied */ | ||
| initialSort?: 'asc' | 'desc' |
Member
There was a problem hiding this comment.
There's already a sortColumnOrder prop exposed via tablePreferences - shouldn't that be sufficient?
| /** This property defines whether sort icon should be displayed next to the column header and whether the column header will emit sort event upon clicking on it */ | ||
| sortable?: boolean | ||
| /** When provided, determines the intial arrow direction on the column */ | ||
| initialSort?: SortColumnOrder |
Member
There was a problem hiding this comment.
There's already a sortColumnOrder prop exposed via tablePreferences - shouldn't that be sufficient?
Member
Member
|
Issues this PR aimed to fix are being fixed in #2819 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Satisfies MA-4062
I'm a little bit opinionated in this PR and I haven't run this past design. Very willing to change anything that's in here, particularly the style choices.
Issues that are addressed by this PR
Description of changes
To address those two concerns, I made two changes. First, we use a different icon to indicate that a column could be sorted. Second, you can provide an
initialSortin your header to make the arrow initialized in the direction you want it to appear.I haven't run these changes past design, so I'm happy to change anything about the styles of this.
Screenshots
arrow position on initial load
before
after
arrow position after clicking on a column
before
after
Initial load with the initialSort set to 'asc'