Skip to content

Conversation

@pmalek
Copy link
Member

@pmalek pmalek commented Aug 5, 2025

This PR makes 2 tests skip.

Here are the issues that track re-enabling them:

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.17%. Comparing base (1f82949) to head (056f959).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
- Coverage   44.26%   44.17%   -0.09%     
==========================================
  Files          57       57              
  Lines        4688     4688              
==========================================
- Hits         2075     2071       -4     
- Misses       2351     2354       +3     
- Partials      262      263       +1     
Flag Coverage Δ
integration-test 48.16% <ø> (-0.10%) ⬇️
unit-test 2.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pmalek pmalek marked this pull request as ready for review August 5, 2025 16:03
@pmalek pmalek requested a review from a team as a code owner August 5, 2025 16:03
@pmalek pmalek enabled auto-merge (squash) August 5, 2025 16:03
alacuku
alacuku previously approved these changes Aug 5, 2025
@pmalek pmalek disabled auto-merge August 5, 2025 19:19
@pmalek pmalek enabled auto-merge (squash) August 5, 2025 19:20
@pmalek pmalek force-pushed the fix-failing-tests branch from 01a3e29 to 3b0d84c Compare August 5, 2025 19:26
@pmalek pmalek force-pushed the fix-failing-tests branch from 3b0d84c to edb10b5 Compare August 5, 2025 19:30
@pmalek pmalek force-pushed the fix-failing-tests branch from edb10b5 to e338732 Compare August 5, 2025 20:11
@pmalek pmalek force-pushed the fix-failing-tests branch from e338732 to 2e8bb41 Compare August 5, 2025 20:18
@pmalek pmalek force-pushed the fix-failing-tests branch from 2e8bb41 to 2b9588c Compare August 6, 2025 08:18
@pmalek
Copy link
Member Author

pmalek commented Aug 6, 2025

Can't merge due to

Code scanning is still expecting 1 result from CodeQL for 5e5e869 or a5f09b6.

Going to look into the repository settings as it seems that there are 2 codeql workloads which can't upload for the same change in the same PR.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@pmalek
Copy link
Member Author

pmalek commented Aug 6, 2025

@alacuku The CI is fixed now. PTAL

@pmalek pmalek merged commit f11c4b1 into main Aug 6, 2025
45 checks passed
@pmalek pmalek deleted the fix-failing-tests branch August 6, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants