Skip to content

fix(accesstoken): Uniform error return type #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
houmkh merged 1 commit into from
Mar 6, 2026
Merged

fix(accesstoken): Uniform error return type #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/resty/gcp/request/credentials/accesstoken.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ function AccessToken:refresh()
return true, self.token, self.expireTime
end

return false, err, nil
return nil, err
end

--- Get a valid access token, automatically refreshing when expired.
Expand All @@ -238,13 +238,13 @@ function AccessToken:get()
local ok, err = self._semaphore:wait(SEMAPHORE_TIMEOUT)
if not ok then
ngx.log(ngx.ERR, "[accesstoken] semaphore wait failed: ", tostring(err))
return false, "semaphore wait failed: " .. tostring(err), nil
return nil, "semaphore wait failed: " .. tostring(err)
end
else
local sema, err = semaphore:new()
if not sema then
ngx.log(ngx.ERR, "[accesstoken] create semaphore failed: ", tostring(err))
return false, "create semaphore failed: " .. tostring(err), nil
return nil, "create semaphore failed: " .. tostring(err)
end
self._semaphore = sema

Expand All @@ -255,7 +255,7 @@ function AccessToken:get()

if not ok then
ngx.log(ngx.ERR, "[accesstoken] failed to get new access token: ", tostring(token_or_err))
return false, "failed to get new access token: " .. tostring(token_or_err), nil
return nil, "failed to get new access token: " .. tostring(token_or_err)
end
end
end
Expand Down
Loading