fix: update mesh defaults hook to process empty slice#67
Closed
harshadixit12 wants to merge 1 commit intomainfrom
Closed
fix: update mesh defaults hook to process empty slice#67harshadixit12 wants to merge 1 commit intomainfrom
harshadixit12 wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we are adding a change to mesh default hook, so that even when the
featuresfield is an empty slice, we add the defaults.This workaround is needed because of a change in speakeasy Marshalling - which now marshals
featuresto[]when not declared. (Discussion started here with speakeasy)Tested on local by replacing the hook, and running the tests on the beta provider.
