fix: collapsible section chevron bug, misc refactors [TDX-6738] #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portikM
requested review from
a team,
DariaYeremina,
ValeryG,
adamdehaven,
jillztom and
vaibhavrajsingh2001
as code owners
Install the preview package from this PR@kong/spec-renderer@pr-738 |
portikM
commented
Oct 27, 2025
afrzhussain
reviewed
Oct 27, 2025
|
|
||
| <script lang="ts" setup> | ||
| import { ref, useAttrs, computed } from 'vue' | ||
| import { ref, useAttrs, computed, useTemplateRef } from 'vue' |
There was a problem hiding this comment.
Suggested change
| import { ref, useAttrs, computed, useTemplateRef } from 'vue' | |
| import { useAttrs, computed, useTemplateRef } from 'vue' |
vaibhavrajsingh2001
requested changes
Oct 30, 2025
Comment on lines
+164
to
167
| const auth2ComponentRef = useTemplateRef<Array<InstanceType<typeof TryItAuth2>>>('auth2ComponentTemplate') | ||
| const auth2ClientCredentialsAuth = async (): Promise<Response | undefined> => { | ||
| if (!auth2ComponentRef.value?.[0].auth2ClientCredentialsAuth) { |
There was a problem hiding this comment.
Let's also remove generic type from here, as it causes type assertion. Let Vue pickup the type itself, as it also helped catch a bug here: we were expecting auth2ComponentRef.value?.[0] to always exist, and hence were directly accessing auth2ClientCredentialsAuth on it.
Suggested change
| const auth2ComponentRef = useTemplateRef<Array<InstanceType<typeof TryItAuth2>>>('auth2ComponentTemplate') | |
| const auth2ClientCredentialsAuth = async (): Promise<Response | undefined> => { | |
| if (!auth2ComponentRef.value?.[0].auth2ClientCredentialsAuth) { | |
| const auth2ComponentRef = useTemplateRef('auth2ComponentTemplate') | |
| const auth2ClientCredentialsAuth = async (): Promise<Response | undefined> => { | |
| if (!auth2ComponentRef.value?.[0]?.auth2ClientCredentialsAuth) { |
| ref="model-property" | ||
| class="model-property" | ||
| ref="modelProperty" | ||
| class="modelProperty" |
There was a problem hiding this comment.
The class name shouldn't be changed.
Suggested change
| class="modelProperty" | |
| class="model-property" |
| const expanded = ref<boolean>(true) | ||
| const toggleState = (e: Event) => { | ||
| if (!(e.target as HTMLElement).dataset.selectDropdownTrigger) { |
There was a problem hiding this comment.
Can you add a comment here on why we need to do this
Comment on lines
+193
to
+196
| useEventListener(popoverTrigger.value, 'mouseenter', showPopover) | ||
| useEventListener(popoverTrigger.value, 'focus', showPopover) | ||
| useEventListener(popoverTrigger.value, 'mouseleave', hidePopover) | ||
| useEventListener(popoverTrigger.value, 'blur', hidePopover) |
There was a problem hiding this comment.
I think we can pass multiple events as an array to useEventListener, like this useEventListener(popoverTrigger.value, ['mouseenter', 'focus'], showPopover).
Can you try it out and verify?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/TDX-6738
Fix CollapsibleSection chevron icon bug when clicking on dropdown in CollapsibleSection title, it toggles the chevron icon (recordings).
Before
https://github.com/user-attachments/assets/f63c54ba-b4d7-4b87-bfad-6879f368007d
After
https://github.com/user-attachments/assets/3212c9a1-6b61-42a7-875f-0d99ccc5dc1d
Other misc refactors:
useTemplateRefin bunch of placesuseEventListenerinstead ofaddEventListenerwhere appropriate