Skip to content

Add option for reuse curl handle#124

Open
yann01240 wants to merge 1 commit intoKong:masterfrom
yann01240:master
Open

Add option for reuse curl handle#124
yann01240 wants to merge 1 commit intoKong:masterfrom
yann01240:master

Conversation

@yann01240
Copy link

It improves performance in multiple queries to avoid SSL handshake at each request.

It improves performance in multiple queries to avoid SSL handshake at each request.
@stokito
Copy link

stokito commented Dec 17, 2017

The whole design of the lib looks for me as a one-time call usage. It doesn't use OOP and stores almost all request configs to a class static variable. This makes managing of state difficult.
As for me, it might be too dangerous to reuse an old curl handler instead of the creation of another one with clear settings.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants