issue 156, avoid PHP 7.4 Notice (array offset on value of type int)#158
Open
ennorehling wants to merge 1 commit intoKong:masterfrom
Open
issue 156, avoid PHP 7.4 Notice (array offset on value of type int)#158ennorehling wants to merge 1 commit intoKong:masterfrom
ennorehling wants to merge 1 commit intoKong:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix issue #156 - $port is an integer, and there is no reason to access it as an array or string.
I noticed there is no test for this, and don't know how to create one. Also, the UnirestRequestTest::testGzip test seems to be failing, but it already did that before my change.