Skip to content

Conversation

@hoc081098
Copy link
Member

@hoc081098 hoc081098 commented Apr 6, 2025

This pull request includes several changes related to the migration from a custom NonEmptySet implementation to the arrow library's NonEmptySet and other project configuration updates. The most important changes are summarized below:

Migration to arrow library's NonEmptySet:

Removal of custom NonEmptySet implementation:

Project configuration updates:

@hoc081098 hoc081098 self-assigned this Apr 6, 2025
@hoc081098 hoc081098 requested a review from Copilot April 6, 2025 12:00
@hoc081098 hoc081098 added enhancement New feature or request deps dependencies Pull requests that update a dependency file labels Apr 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • .idea/AndroidProjectSystem.xml: Language not supported
  • .idea/kotlinc.xml: Language not supported
  • .idea/runConfigurations.xml: Language not supported
  • .idea/vcs.xml: Language not supported
Comments suppressed due to low confidence (2)

core/src/test/java/com/hoc/flowmvi/core/NonEmptySetTest.kt:1

  • The custom NonEmptySet tests have been removed; please ensure that the critical behaviors of Arrow's NonEmptySet used in our codebase are covered by other tests.
package com.hoc.flowmvi.core

domain/src/main/java/com/hoc/flowmvi/domain/model/UserError.kt:6

  • Converting NetworkError from an object to a data object may change identity semantics; please verify that this change is intentional and that equality checks in the codebase function as expected.
data object NetworkError : UserError() {

@codecov
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.63%. Comparing base (34836e0) to head (14a14f0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   61.63%   61.63%           
=======================================
  Files          37       37           
  Lines        1100     1100           
  Branches      104      104           
=======================================
  Hits          678      678           
  Misses        408      408           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hoc081098 hoc081098 merged commit 78c98c6 into master Apr 6, 2025
8 checks passed
@hoc081098 hoc081098 deleted the NonEmptySet branch April 6, 2025 12:05
@AlphaAndOmage
Copy link
Collaborator

AlphaAndOmage commented Apr 6, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file deps enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants