Skip to content

refactor: simplify zipOrAccumulateNonEmptySet implementation #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

refactor: simplify zipOrAccumulateNonEmptySet implementation #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 8 additions & 33 deletions core/src/main/java/com/hoc/flowmvi/core/EitherNes.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ import arrow.core.NonEmptySet
import arrow.core.left
import arrow.core.nonEmptySetOf
import arrow.core.right
import arrow.core.toNonEmptySetOrNull
import kotlin.contracts.ExperimentalContracts
import kotlin.contracts.InvocationKind
import kotlin.contracts.contract

/**
* A typealias for [Either] with [NonEmptySet] as the left side.
Expand All @@ -21,37 +17,16 @@ inline fun <A> A.rightNes(): EitherNes<Nothing, A> = this.right()
@Suppress("NOTHING_TO_INLINE")
inline fun <E> E.leftNes(): EitherNes<E, Nothing> = nonEmptySetOf(this).left()

@OptIn(ExperimentalContracts::class)
inline fun <E, A, B, C, Z> Either.Companion.zipOrAccumulateNonEmptySet(
a: EitherNes<E, A>,
b: EitherNes<E, B>,
c: EitherNes<E, C>,
transform: (A, B, C) -> Z,
): EitherNes<E, Z> {
contract { callsInPlace(transform, InvocationKind.AT_MOST_ONCE) }

return if (
a is Either.Right &&
b is Either.Right &&
c is Either.Right
) {
Either.Right(
transform(
a.value,
b.value,
c.value,
),
)
} else {
Either.Left(
buildSet(capacity = a.count + b.count + c.count) {
if (a is Either.Left) this.addAll(a.value)
if (b is Either.Left) this.addAll(b.value)
if (c is Either.Left) this.addAll(c.value)
}.toNonEmptySetOrNull()!!,
)
}
}

@PublishedApi
internal inline val <L, R> Either<L, R>.count: Int get() = if (isRight()) 1 else 0
): EitherNes<E, Z> =
zipOrAccumulate(
combine = { acc, value -> acc + value },
a = a,
b = b,
c = c,
transform = transform,
)
Loading