Skip to content

Load dataframe-jupyter from core in notebooks #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 18, 2025
Merged

Load dataframe-jupyter from core in notebooks #1415

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
334a6d9
adds libraries.json which loads dataframe-jupyter from dataframe-core…
Jolanrensen Aug 28, 2025
3709a8d
Merge branch 'master' into load-jupyter-from-core
Jolanrensen Sep 16, 2025
5841bc8
bumping (min) jupyter kernel versions for libraries.json update
Jolanrensen Sep 16, 2025
533ac2e
Merge branch 'refs/heads/master' into load-jupyter-from-core
Jolanrensen Sep 16, 2025
168d87e
moved libraries.json to be auto-generated on publishing :core only.
Jolanrensen Sep 17, 2025
10bd417
added includeCoreLibrariesJson parameter
Jolanrensen Sep 17, 2025
7a5cf9b
added project.version as input for generateLibrariesJson
Jolanrensen Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/main/resources/META-INF/kotlin-jupyter-libraries/libraries.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"descriptors": [
{
"init": [
"@Suppress(\"INVISIBLE_MEMBER\", \"INVISIBLE_REFERENCE\") USE { dependencies(\"org.jetbrains.kotlinx:dataframe-jupyter:${org.jetbrains.kotlinx.dataframe.BuildConfig.VERSION}\") }"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it public or semi-hidden through some hacks? This suppress warning can break in future versions of kotlin

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's internal, so basically semi-hidden, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion we could also add it to a companion object of DataFrame, like DataFrame.VERSION; doesn't even need to be hidden

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semi hidden but also avoid suppressing invisible reference :)
DataFrame.VERSION idk, not worth to pollute IO scope with it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might not need it after all :) Currently, the tests in dataframe-jupyter are failing because the libraries.json is in the classpath. I'm trying to generate and include it on the fly upon publishing only

]
}
]
}
2 changes: 1 addition & 1 deletion dataframe-jupyter/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/Integration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ import kotlin.reflect.KType
import kotlin.reflect.full.isSubtypeOf

/** Users will get an error if their Kotlin Jupyter kernel is older than this version. */
private const val MIN_KERNEL_VERSION = "0.11.0.198"
private const val MIN_KERNEL_VERSION = "0.15.0.606"

internal val newDataSchemas = mutableListOf<KClass<*>>()

Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[versions]
ksp = "2.2.20-2.0.2"
kotlinJupyter = "0.15.0-587"
kotlinJupyter = "0.15.0-629"

ktlint = "12.3.0"

Expand Down