Add move before #1474
Add move before #1474
Conversation
|
|
||
| @Deprecated(DEPRECATED_ACCESS_API) | ||
| @AccessApiOverload | ||
| public fun <T, C> MoveClause<T, C>.before(column: AnyColumnReference): DataFrame<T> = before { column } |
There was a problem hiding this comment.
no need to add these deprecated overloads :)
There was a problem hiding this comment.
I'll remove them
| return removeResult.df.insertImpl(toInsert) | ||
| } | ||
|
|
||
| // move target after last of toInsert |
There was a problem hiding this comment.
could you expand this doc a bit? I have a bit of a hard time understanding the logic below.
so... you insert the removed columns after the target column in the first place, and then you move the target column after the removed/inserted columns?
That's... really clever :D
But it took me a while to get it :) so please expand the doc a tiny bit :)
There was a problem hiding this comment.
Thank you very much, I appreciate it. That's exactly the logic. I'll try to make the doc more undesrtandable.
|
I implemented requested changes, In addition I noticed a bug when the function throws exception, so i fixed it. |
Solves issue #1021. It comes with a test case which is inspired by after's test case.