Skip to content

Conversation

Jolanrensen
Copy link
Collaborator

No description provided.

@Jolanrensen Jolanrensen requested a review from koperagen October 14, 2025 15:12
@Jolanrensen Jolanrensen added the Compiler plugin Anything related to the DataFrame Compiler Plugin label Oct 14, 2025
@Jolanrensen Jolanrensen added this to the 1.0.0-Beta4 milestone Oct 14, 2025
* a path in the [DataFrame] to move columns.
*/
@Refine
@Interpretable("MoveInto1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What use cases this would support?

Copy link
Collaborator Author

@Jolanrensen Jolanrensen Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see the issue now... I assumed:

move { col }.into { pathOf("some", "new", "path") }, assuming the CS DSL in the compiler plugin supports pathOf() and "path"["of"] :)

And move { col }.into { someColGroup["newName"] }

but it also supports multiple cols with the new name depending on the column given...
It's like a rename.into + move.under

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that's also the problem with rename.into {} isn't it? we don't know how the user uses the old name or any other column data to generate the new name...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as user can write arbitraty code in the lambda such powerful operations are somewhat impossible to implement in the plugin =( shortcuts like rename { }.removePrefix could cover most popular usages though. Didn't think about move into yet

So let's remove these two for now

@Jolanrensen Jolanrensen changed the title added annotations for moveTo(), move {}.into {}, and .intoIndexed {}, to add compiler plugin support added annotations for moveTo()~, move {}.into {}, and .intoIndexed {},~ to add compiler plugin support Oct 14, 2025
@Jolanrensen Jolanrensen changed the title added annotations for moveTo()~, move {}.into {}, and .intoIndexed {},~ to add compiler plugin support added annotations for moveTo() ~~, move {}.into {}, and .intoIndexed {},~~ to add compiler plugin support Oct 14, 2025
@Jolanrensen Jolanrensen changed the title added annotations for moveTo() ~~, move {}.into {}, and .intoIndexed {},~~ to add compiler plugin support added annotations for moveTo() to add compiler plugin support Oct 14, 2025
@Jolanrensen Jolanrensen merged commit 4b1e0a3 into master Oct 14, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler plugin Anything related to the DataFrame Compiler Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants