DataFrameSchema.equals()
including order and CompareResult.Matches
#1505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1502
and fixes the fact that
dataFrameOf(a, b, c) != dataFrameOf(a, c, b)
but this used to be
dataFrameOf(a, b, c).schema() == dataFrameOf(a, c, b).schema()
DataSchema.equals()
with.compare()
(This will also carefully need to be checked in the compiler plugin, though I think.compare()
is already used there, which is good!)DataSchema.equals()
to only returntrue
if the order matches as wellmove {}
tests in the compiler plugin! Because we can now checkcompileTimeSchema() == runTimeSchema()
and the order is checked too)CompareResult.Equals
withMatches
. Usages in the library are updated, but this will also need to be updated in the compiler plugin.CompareResult.Equals
as "equals exactly with order")